Conversation
make tdwii_config look for configuration files relative to executable (sys.argv[0]) if __file__ isn't found which is the situation when the app is built in to an exe
add build-executables CI workflow (manual trigger)
Reviewer's GuideThis PR adds PyInstaller support by updating project dependencies and CI configuration to build and package executables, enhances file‐path resolution in key modules to fall back on the executable directory when file is unavailable, and includes a minor help‐message formatting cleanup. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @sjswerdloff - I've reviewed your changes - here's some feedback:
- Extract and centralize the fallback logic for resolving config paths into a shared helper instead of duplicating it across multiple modules.
- Use PyInstaller’s --add-data option or a dedicated packaging script to include config/data files, rather than manual copy commands in the GitHub Actions workflow.
- Parameterize OS-specific path separators and build steps in the CI workflow to simplify extending support to macOS and Linux builds.
Here's what I looked at during the review
- 🟡 General issues: 4 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…ion (2.x) already
correct to FileNotFoundError Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
removed platform-name and path-sep because they aren't being used. Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
corrected name of upload artefact Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
The configuration files have to be modified by the user after installation, so --add-data isn't appropriate. |
and touch up modules that were hardcoding file to use for relative offsets.
Summary by Sourcery
Prepare project for PyInstaller builds by adding executable packaging support, updating resource path handling for bundled apps, and introducing a CI workflow.
New Features:
Enhancements:
Build:
CI: