-
Notifications
You must be signed in to change notification settings - Fork 37
Enhancement/478 container size #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reworks the build process for release containers to address issue #478 related to container size optimization. The changes move the heavy build process out of Docker containers and into GitHub Actions workflows, resulting in smaller runtime containers that only contain pre-built binaries.
Key changes include:
- Added parallel build support using CPU core detection across build scripts
- Moved SGX SDK/PSW installation and dependency building from Dockerfiles to GitHub Actions workflows
- Updated container architecture to copy pre-built binaries rather than building from source
- Added cleanup procedures to reduce build artifacts and container size
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/build_deps.py | Added CPU core detection and parallel build flags, plus cleanup procedures |
| jsonrpc/build.sh | Simplified build script with parallel make and updated git checkout |
| DockerfileSimulation | Converted to runtime-only container copying pre-built binaries |
| DockerfileRelease | Converted to runtime-only container copying pre-built binaries |
| DockerfileIntelSubmission | Converted to runtime-only container copying pre-built binaries |
| DockerfileBase | Optimized build layers and added cleanup procedures |
| Dockerfile | Converted to runtime-only container copying pre-built binaries |
| .github/workflows/*.yml | Added host-based build steps before Docker container creation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fixed #478
reworked build process for release containers