WIP: add SDLImageInterface #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaupper
requested changes
Sep 3, 2017
| ) | ||
| include/bkengine/core/impl/SDLImageTexture.h | ||
| include/bkengine/exceptions/NotImplementedException.h | ||
| src/utils/InterfaceContainer.cpp |
There was a problem hiding this comment.
Why are you mixing .h and .cpp files here?
| src/core/impl/SDLImageTexture.cpp | ||
| ) | ||
|
|
||
| SET(HEADERS include/bkengine/core/builder/templates/AnimationBuilder_templates.h |
There was a problem hiding this comment.
Wasn't that part of the most recent PR?
| { | ||
| public: | ||
| virtual void init(); | ||
| virtual void cleanup(); |
There was a problem hiding this comment.
I am curious where you wanna call these two methods^^
(static constructor)
| return nullptr; | ||
| } | ||
|
|
||
| //TODO: add renderer when GraphicsInterface is finished |
There was a problem hiding this comment.
Well that is going to be a problem...
| SDL_Texture *raw_texture = SDL_CreateTextureFromSurface(nullptr, raw_surface); | ||
| SDL_FreeSurface(raw_surface); | ||
|
|
||
| std::shared_ptr<SDLImageTexture> texture(new SDLImageTexture(raw_texture)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.