Remove optional approval-settings note from step 1 - #71
Merged
Conversation
The exercise now advances automatically on PR merge, so the optional guidance about the Actions approval setting is no longer needed. Removes the NOTE block and the referenced settings-actions-general-approvals.png image. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 76eaf9b1-bc5b-454f-b3ed-5f50fb9968f4
Contributor
There was a problem hiding this comment.
Pull request overview
Removes now-unnecessary optional guidance about GitHub Actions approval settings from Step 1 of the learning exercise, aligning the instructions with the updated behavior where the exercise advances automatically on PR merge.
Changes:
- Removed the optional
NOTEblock about “Require approval for first-time contributors…” from.github/steps/1-step.md. - Removed the now-unreferenced screenshot image previously used by that note.
Show a summary per file
| File | Description |
|---|---|
| .github/steps/1-step.md | Deletes the optional approval-settings note + embedded image reference to reduce learner confusion. |
| .github/images/settings-actions-general-approvals.png | Removes the screenshot asset that is no longer referenced. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The exercise now advances automatically when the learner merges their pull request, so the optional guidance about configuring the Actions "Require approval for first-time contributors" setting is no longer needed. Leaving it in adds noise and can confuse learners into thinking a settings change is required to progress.
What changed
NOTEblock in.github/steps/1-step.mdthat described the approval-settings workaround..github/images/settings-actions-general-approvals.png.No other step content is affected.