Fix Step 1 workflow activation - #73
Merged
Merged
Conversation
Remove redundant workflow disable commands that fail when the exercise toolkit has already disabled those workflows. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d523f2fa-5ffe-4981-846a-3627b824bae9
Use the Actions API with workflow filenames so Steps 2 and 3 are disabled regardless of their current state before Step 1 is enabled. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d523f2fa-5ffe-4981-846a-3627b824bae9
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Step 0 (“Start Exercise”) GitHub Actions workflow to avoid failing exercise initialization when step workflows are already disabled, by removing redundant disable calls and only enabling Step 1.
Changes:
- Remove the sequence of
gh workflow disable ...calls for Step 1–3 and the current workflow. - Keep the initialization flow moving by enabling Step 1 directly via
gh workflow enable.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/0-start-exercise.yml | Simplifies workflow activation logic to avoid failing when workflows are already disabled and to ensure Step 1 is enabled for learners to continue. |
Review details
Tip
Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
Use the workflow file name so Step 0 is disabled idempotently after enabling Step 1. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d523f2fa-5ffe-4981-846a-3627b824bae9
Select workflows by filename so disabled workflows resolve reliably while retaining the gh workflow client commands. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d523f2fa-5ffe-4981-846a-3627b824bae9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exercise setup fails after the toolkit disables all step workflows because display-name lookup does not resolve an already-disabled workflow reliably.
Keep using the
gh workflowclient, but select workflows by filename. Step 0 explicitly disables Steps 2 and 3, enables Step 1, and then disables itself after the handoff.