Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the stanza_resources download #217

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

raina-rudra
Copy link
Collaborator

The old method of download stanza resources was not working, fixed it.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.89%. Comparing base (1ee67a0) to head (442b015).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
...ialogy/plugins/text/list_search_plugin/__init__.py 50.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1ee67a0) and HEAD (442b015). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (1ee67a0) HEAD (442b015)
unittests 4 2
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #217       +/-   ##
===========================================
- Coverage   99.84%   88.89%   -10.95%     
===========================================
  Files          55       63        +8     
  Lines        2646     3216      +570     
===========================================
+ Hits         2642     2859      +217     
- Misses          4      357      +353     
Flag Coverage Δ
unittests 88.89% <50.00%> (-10.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raina-rudra raina-rudra merged commit 32aeba5 into master Jan 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants