Update readme, clean up

README.md

@@ -29,17 +29,18 @@ Temporarily disable boost (untill next reboot) for AMD:
 
  > echo "0" | sudo tee /sys/devices/system/cpu/cpufreq/boost
 
-
-
 The JMH plugin seems to have trouble refreshing the project, so restart the Gradle deamon before running.
 ## Benchmarks
 
   * Parse token (if possible)
   * Verify token
   * Verify token, get claim.
 
-## General observations
-There is not much headroom for improving the performance further. Most of the CPU time goes to signature verification.
+## General performance observations
+There is not much headroom for improving the performance of RSA-based signatures; most (> 90%) of the CPU time goes to signature verification. 
+
+This observation is based on two simple 'baseline' RSA-based JWT verifiers included in this project. They perform about 5% faster than the fastest JWT libraries, 
+but then only does signature verification and no JSON parsing / field validation. So it seems likely this is the upper limit.
 
 ## Latest results
 Running for OpenJDK 11 build 11.0.18+10 and OpenJDK 17 build 17.0.6+10, on Fedora Linux 6.1.8-200, AMD Ryzen 5950.

build.gradle

@@ -76,7 +76,7 @@ configure(project(':jmh-benchmark')) {
         warmup = '1s' // Time to spend at each warmup iteration.
         warmupIterations = 10
 
-        includes = ['JwtVerifyBenchmark']
+        // includes = ['JwtVerifyBenchmark']
 
         fork = 1
         timeOnIteration = '5s'

jmh-benchmark/src/jmh/java/com/github/skjolber/jwt/JwtClaimBenchmark.java

@@ -2,7 +2,7 @@
 
 import org.openjdk.jmh.annotations.Benchmark;
 
-public abstract class JwtClaimBenchmark {
+public class JwtClaimBenchmark {
 
     @Benchmark
     public Object nimbus_claim(BenchmarkState state) throws Exception {
@@ -31,5 +31,4 @@ public Object fusionauth_claim(BenchmarkState state) throws Exception {
         return state.getFusionAuthJsonWebTokenVerifier().verifyJsonWebToken(state.getToken()).getObject("test");
     }
 
-
 }

jmh-benchmark/src/jmh/java/com/github/skjolber/jwt/JwtParseBenchmark.java

@@ -6,7 +6,7 @@
 
 import java.text.ParseException;
 
-public abstract class JwtParseBenchmark {
+public class JwtParseBenchmark {
 
     @Benchmark
     public com.nimbusds.jwt.JWT nimbus_parse(BenchmarkState state) throws ParseException {

jmh-benchmark/src/jmh/java/com/github/skjolber/jwt/JwtVerifyBenchmark.java

@@ -22,7 +22,6 @@
 @Measurement(iterations = 1, time = 30, timeUnit = TimeUnit.SECONDS)
 public class JwtVerifyBenchmark {
 
-    /*
     @Benchmark
     public Object nimbus_verify(BenchmarkState state) throws Exception {
         return state.getNimbusTokenVerifier().verifyJsonWebToken(state.getToken());
@@ -37,15 +36,13 @@ public Object jjwt_verify(BenchmarkState state) throws Exception {
     public Object auth0_verify(BenchmarkState state) throws Exception {
         return state.getAuth0TokenVerifier().verifyJsonWebToken(state.getToken());
     }
-*/
-        /*
 
+    /*
     @Benchmark
     public Object okta_verify(BenchmarkState state) throws Exception {
         return state.getOktaJsonWebTokenVerifier().verifyJsonWebToken(state.getToken());
     }
-
-         */
+    */
 
     @Benchmark
     public Object fusionauth_verify(BenchmarkState state) throws Exception {