Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapped c to greek letter ψ in the greeklish generator #18

Open
wants to merge 3 commits into
base: 5.4.2
Choose a base branch
from

Conversation

galanis-a
Copy link

No description provided.

@greenonion
Copy link
Member

@galanis-a hey, thanks for this PR. Could you please give the rationale behind the change and its intended effect? I am not sure c is a valid greeklish substitute for ψ. e.g ψωμι would be psomi or pswmi but not cwmi or comi.

@galanis-a
Copy link
Author

Hello @greenonion,

i added this because when you try typing somehting like vichy with greek letter is ωιψηυ, The c letter is ψ in this case. So i think c can map to ψ as well as ps.

@greenonion
Copy link
Member

greenonion commented Oct 23, 2019

I imagined that would be the case. Unfortunately, this is out of scope for this plugin, as it only tries to handle Greek words written using Latin characters, not the other way round. Our wiki has an example.

We could possibly add a setting to enable/disable this functionality though, but currently this is low priority for us. If you're interested we could guide you through it.

@galanis-a
Copy link
Author

Yeah sure would love your help on making the setting.

@galanis-a
Copy link
Author

Hello @greenonion,

I added the setting for the special mapping to map c to ψ.
Also update the test files and testing on my local elasticsearch server.
But the only name i came up is "special mapping", don't think its pretty good. If you could help on this, and come up with something that would match better.

Best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants