Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] adapter to lifelines, most distributional survival regressors interfaced #247

Merged
merged 34 commits into from
Apr 17, 2024
Merged

[ENH] adapter to lifelines, most distributional survival regressors interfaced #247

merged 34 commits into from
Apr 17, 2024

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Apr 16, 2024 •
edited
Loading

Adds an adapter to lifelines, exposing array-like survival functions as Empirical distributions in predict_proba.

Adds all models from lifelines which are capable of full distributional predictions:

  • AalenAdditiveFitter
  • CoxPHFitter
  • WeibullAFTFitter

Remaining AFT fitters require distributions not yet merged.

@fkiraly fkiraly added enhancement interfacing algorithms Interfacing existing algorithms/estimators from third party packages module:survival&time-to-event module for time-to-event prediction aka survival prediction labels Apr 16, 2024
@fkiraly fkiraly marked this pull request as draft April 17, 2024 00:02
@fkiraly
Copy link
Collaborator Author

fkiraly commented Apr 17, 2024 •
edited
Loading

AalenAdditiveFitter fails as it produces improper survival functions.
I have added an skpro sided fix, which is clipping to proper distributions.

Bug with AalenAdditive reported here: CamDavidsonPilon/lifelines#1606

@fkiraly fkiraly changed the title [ENH] adapter to lifelines, all distributional survival regressors interfaced [ENH] adapter to lifelines, most distributional survival regressors interfaced Apr 17, 2024
@fkiraly fkiraly marked this pull request as ready for review April 17, 2024 23:11
@fkiraly fkiraly merged commit e2862a5 into main Apr 17, 2024
34 checks passed
@fkiraly fkiraly mentioned this pull request May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement interfacing algorithms Interfacing existing algorithms/estimators from third party packages module:survival&time-to-event module for time-to-event prediction aka survival prediction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fkiraly