-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding lots of new tests for the tutorial and solution #64
Draft
Nickname5862
wants to merge
31
commits into
main
Choose a base branch
from
expansion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally fixed the broken imports of sherlock and sherlock-utils
Use npm run tutorial to run all the test cases in the tutorial directory.
Note that it's currently skipping the test cases. They have been validated to run (and fail) before committing though.
Again skipping by default.
There's still one part at line 121 where I'm not sure what's happening
As always, set to skip by default.
Some weird config/import spaghetti was going on. Now everything works with the '@' import notation. Co-authored-by: Paco van der Linden <[email protected]>
Currently skipped as always. Also removed some unused pieces of code: - Imports - Outer test suite that didn't do anything useful
Still have to iron out some details probably
Probably have to tweak it a bit more though
This way it doesn't count as a failed test case when running npm run tutorial.
Also updated a comment in tutorial 1 slightly.
Nickname5862
changed the title
Expansion
feat: adding lots of new tests for the tutorial and solution
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of new tests have been added to the tutorial part of Sherlock. These include:
7 - advanced
with8 - util
to be able to use advanced techniques in the utils.reactor options order of execution (3)
,fallback-to (5)
,errors (6)
,templates, take, map on arrays, mapState, flatMap, states, pluck (7)
, andpairwise/scan on normal arrays, peek, lift, final, promise, fromObservable, fromEventPattern... (8)
.generator
folder rather than directly in thetutorial
orsolution
folder.generateTutorialAndSolution
file has created to automatically transform the files in thegenerator
folder to the tutorial and solution files in thetutorial
andsolution
folders. This way, a single change has to be made in the generator files which is immediately propagated to changes in the tutorial and solution files when using the commandnpm run generate
.TODO: new things can still be added to the tutorial, such as:
atomic()
function - allowing multiple atoms to be changed simultaneously without triggering aderive
orreact
update in-between)TODO: also check how you can make sure that this
Semantic PRs
automatically makes a changelog for me.But that's for another KipSate!