Skip to content

Fixes #1790: When a PN_TRANSPORT_ERROR event is received, immediately… #1796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025
Merged

Fixes #1790: When a PN_TRANSPORT_ERROR event is received, immediately… #1796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/adaptors/amqp/qd_connection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,6 +821,8 @@ bool qd_connection_handle_event(qd_server_t *qd_server, pn_event_t *e, void *con
pn_condition_get_description(condition));
}
}
pn_connection_write_flush(pn_conn);
pn_transport_close_head(transport);
}
break;

Expand Down
3 changes: 3 additions & 0 deletions tests/system_tests_tcp_adaptor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1298,6 +1298,7 @@ def test_01_ignore_stuck_deliveries(self):
server.bind(("", self.interior_tcp_connector_port))
server.listen(10)
except Exception as exc:
server.close()
print("%s: failed creating tcp server: %s" % (self.test_name, exc),
flush=True)
raise
Expand Down Expand Up @@ -1834,6 +1835,7 @@ def _test_listener_socket_lifecycle(self,
# There may be a delay between the operStatus going up and
# the actual listener socket availability, so allow that:
time.sleep(0.1)
client_conn.close()
continue

server_conn, _ = server.accept()
Expand Down Expand Up @@ -1864,6 +1866,7 @@ def _test_listener_socket_lifecycle(self,
continue
except ConnectionRefusedError:
# Test successful
client_conn.close()
break

l_mgmt.delete(type=TCP_LISTENER_TYPE, name=listener_name)
Expand Down