Lang German added #165
Open
Lang German added #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot @Laurin-migi 👍 Any reason why this PR is targeting v2/main (Umbraco 8) and not v4/main (Umbraco 10+)? |
yes, thats because we use umbraco v8 and we will use umvraco 10 later. When I have time, I will make a new PR with v10 |
abjerner
requested changes
Feb 14, 2023
There was a problem hiding this comment.
Hi @Laurin-migi
I've found a minor issue. Even for the German translation, this is supposed to be the English word Content, right?
If you can look into this, I'd be happy to merge, and then push a new release for Umbraco 8 😉
| <key alias="reload">Neu laden</key> | ||
| <key alias="edit">Bearbeiten</key> | ||
| <key alias="delete">Löschen</key> | ||
| <key alias="content">Contet</key> |
There was a problem hiding this comment.
Shouldn't this be Content like line 40?
limbobot
added
umbraco/v8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I come from Switzerland and have therefore added a German language to your great package.