Overwrite character in names #91

[flicker71]

I do the issue #91
I hope it will be accepted

Result of home

Result of pokemon Detail

I explained my changes directly in the code, but here's a brief summary.

I had to modify the Pokemon data class because the 'name' field was declared as 'val,' making it immutable. I changed it to 'var' to allow modifications to this value. Additionally, I added a simple 'replace' statement in both the PokemonAdapter and the DetailActivity to modify the value.

Guidelines

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce?

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Preparing a pull request for review

Ensure your change is properly formatted by running:

$ ./gradlew spotlessApply

Please correct any failures before requesting a review.

[inson1]

@flicker71 https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

[inson1]

@flicker71 btw did you though about Pokemons, that actually have "-" in their name? There should be some exception list, right?

by these pokedex there is 9 of these pokemons
https://pokemondb.net/pokedex/all
https://www.pokemon.com/us/pokedex

Sorry that I didnt include it in the fr, I thought about it only now

Or I'm wrong?

[skydoves]

Hey @flicker71, thanks for working on this PR! It would be great if we can incorporate this logic into the #165.