Improvements :D #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluix-dev
reviewed
May 30, 2021
about/index.html
Outdated
| </div> | ||
| </body> | ||
|
|
||
| </html> |
There was a problem hiding this comment.
As someone who has 0 stake in anything here, please keep the newlines here (and everywhere else). They're nice.
about/index.html
Outdated
| <div class="wrapper"> | ||
| <div class="contact-list"> | ||
| <a class="contact" href="https://www.instagram.com/cuilu.vp" target="_blank"> | ||
| <img class="contact-icon" src="../img/insta-icon.svg"> |
There was a problem hiding this comment.
May as well remove all relative links.
rcshim04
approved these changes
May 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
target="_blank"links (security)You might wanna fill in the description yourself, also you called the
resized()function from hamburger.js on page load when it didn't exist (it's loaded in body after the function call) :p