Skip to content

Commit

Permalink
wip
Browse files Browse the repository at this point in the history
  • Loading branch information
weih1121 committed Jan 3, 2025
1 parent 20a264a commit 346b963
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
1 change: 1 addition & 0 deletions sky/backends/backend_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -807,6 +807,7 @@ def write_cluster_config(
if (remote_identity_config ==
schemas.RemoteIdentityOptions.NO_UPLOAD.value):
excluded_clouds.add(cloud_obj)

credentials = sky_check.get_cloud_credential_file_mounts(excluded_clouds)
auth_config = {'ssh_private_key': auth.PRIVATE_SSH_KEY_PATH}
region_name = resources_vars.get('region')
Expand Down
13 changes: 6 additions & 7 deletions sky/backends/cloud_vm_ray_backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
from typing import (Any, Callable, Dict, Iterable, List, Optional, Set, Tuple,
Union)

import click
import colorama
import filelock

Expand Down Expand Up @@ -2008,12 +2007,12 @@ def provision_with_retries(
enabled_clouds)

if len(expirable_clouds) > 0:
warnings = (f'\nWarning: Expiring credentials detected for '
f'{expirable_clouds}. Clusters may be leaked if '
f'the credentials expire while jobs are running. '
f'It is recommended to use credentials that never'
f' expire or a service account.')
click.secho(warnings, fg='yellow')
warnings = (f'\n\033[93m Warning: Credentials used for '
f'{expirable_clouds} may expire.Clusters may be '
f'leaked if the credentials expire while jobs '
f'are running.It is recommended to use credentials'
f' that never expire or a service account.\033[0m')
logger.warning(warnings)

# Retrying launchable resources.
while True:
Expand Down

0 comments on commit 346b963

Please sign in to comment.