Skip to content

Commit

Permalink
fix bug
Browse files Browse the repository at this point in the history
  • Loading branch information
zpoint committed Jan 12, 2025
1 parent 1ba1d06 commit 8cd0740
Showing 1 changed file with 12 additions and 11 deletions.
23 changes: 12 additions & 11 deletions .buildkite/generate_pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,21 +88,22 @@ def _extract_marked_tests(
function_name_marks_map = collections.defaultdict(set)
function_name_param_map = collections.defaultdict(list)
for function_name, marks in matches:
clean_function_name = re.sub(r'\[.*?\]', '', function_name)
marks = marks.replace('\'', '').split(',')
marks = [i.strip() for i in marks]
function_name_marks_map[function_name].update(marks)
if 'serve' in marks and '[' in function_name:
# example: test_skyserve_new_autoscaler_update[rolling]
# param: rolling
# function_name: test_skyserve_new_autoscaler_update
# Separate serve tests with different parameters to different steps
# for parallel execution
function_name_marks_map[clean_function_name].update(marks)

# extract parameter from function name
# example: test_skyserve_new_autoscaler_update[rolling]
# param: rolling
# function_name: test_skyserve_new_autoscaler_update
param = None
if '[' in function_name and 'serve' in marks:
# Only serve tests are slow and flaky, so we separate them
# to different steps for parallel execution
param = re.search('\[(.+?)\]', function_name).group(1)
function_name = re.search('(.+?)\[', function_name).group(1)
else:
param = None
if param:
function_name_param_map[function_name].append(param)
function_name_param_map[clean_function_name].append(param)

function_cloud_map = {}
filter_marks = set(filter_marks)
Expand Down

0 comments on commit 8cd0740

Please sign in to comment.