Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DigitalOcean] droplet integration #3832

Merged
merged 85 commits into from
Jan 2, 2025
Merged

Conversation

asaiacai
Copy link
Contributor

@asaiacai asaiacai commented Aug 14, 2024

This adds digital ocean droplets to the sky.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • All smoke tests: pytest tests/test_smoke.py --do

@moinnadeem
Copy link

@asaiacai I would be really interested in using this work -- do you know when you might be able to land this PR?

@asaiacai
Copy link
Contributor Author

asaiacai commented Aug 31, 2024 via email

@asaiacai asaiacai marked this pull request as ready for review September 11, 2024 00:07
@asaiacai
Copy link
Contributor Author

@Michaelvll i think this PR is finally ready, once you have a free moment! I've currently disabled tests for gpu droplets as they are still in early access, but I think I got the remaining tests to work on normal CPU droplets fine. Let me know if you find any issues.

@asaiacai
Copy link
Contributor Author

also this catalog update is required to pass the sky serve requests since I added cheaper 2vcpu instances.

skypilot-org/skypilot-catalog#83

@Michaelvll Michaelvll requested a review from cblmemo September 11, 2024 08:05
Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this amazing work @asaiacai ! This would be very helpful. Left some discussions ;)

docs/source/getting-started/installation.rst Outdated Show resolved Hide resolved
sky/adaptors/do.py Show resolved Hide resolved
sky/clouds/do.py Outdated Show resolved Hide resolved
sky/clouds/do.py Outdated Show resolved Hide resolved
sky/clouds/do.py Outdated Show resolved Hide resolved
sky/templates/do-ray.yml.j2 Show resolved Hide resolved
tests/test_smoke.py Outdated Show resolved Hide resolved
tests/skyserve/update/bump_version_after.yaml Outdated Show resolved Hide resolved
sky/clouds/do.py Outdated Show resolved Hide resolved
sky/clouds/do.py Show resolved Hide resolved
asaiacai and others added 2 commits September 17, 2024 12:45
@asaiacai
Copy link
Contributor Author

@cblmemo smoke tests are passing on my end. the catalog PR should fix the CI failures.

@cblmemo
Copy link
Collaborator

cblmemo commented Dec 31, 2024

@cblmemo smoke tests are passing on my end. the catalog PR should fix the CI failures.

Thanks! QQ: Which catalog PR should I merge? Both skypilot-org/skypilot-catalog#83 and skypilot-org/skypilot-catalog#103?

Also, just want to make sure, does the CI passed in your side when merging the above mentioned catalog PRs?

@asaiacai
Copy link
Contributor Author

only skypilot-org/skypilot-catalog#103

pushed an update to the test_optimizer_dryrun since there are no T4 or 32 memory instances on DO.
rest of the CI passes for me with this change

@cblmemo
Copy link
Collaborator

cblmemo commented Dec 31, 2024

only skypilot-org/skypilot-catalog#103

pushed an update to the test_optimizer_dryrun since there are no T4 or 32 memory instances on DO. rest of the CI passes for me with this change

Just curious, why do has no 32 memory instance? is it because all of them have higher memory?

Also, I think there is other cloud that has no T4 instance. Could you help check why the original test works for them but not do?

$ sky show-gpus T4 --cloud fluidstack
Resources 'T4' not found on Fluidstack. To show available accelerators, run: sky show-gpus --all

@asaiacai
Copy link
Contributor Author

Just curious, why do has no 32 memory instance? is it because all of them have higher memory?

sorry for the back and forth here. The catalog was missing some instances with 32GB capability, which I just added to the catalog PR only skypilot-org/skypilot-catalog#103 I reverted tests/test_optimizer_dryruns.py back. so the last of the tests here are passing.

Also, I think there is other cloud that has no T4 instance. Could you help check why the original test works for them but not do?
The filter against DO for the T4 case was removed, and the test case passes like Fluidstack now.

@cblmemo
Copy link
Collaborator

cblmemo commented Jan 2, 2025

Thanks @asaiacai ! Just merged the catalog PR. Re-running unittest now and after it passed it should be ready to go!

@cblmemo cblmemo merged commit 51bca22 into skypilot-org:master Jan 2, 2025
19 checks passed
@asaiacai asaiacai deleted the droplet branch January 2, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants