-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DigitalOcean] droplet integration #3832
Conversation
@asaiacai I would be really interested in using this work -- do you know when you might be able to land this PR? |
Hello! I’m aiming for this to land in next two weeks providing testing goes
smoothly. Stay tuned!
|
@Michaelvll i think this PR is finally ready, once you have a free moment! I've currently disabled tests for gpu droplets as they are still in early access, but I think I got the remaining tests to work on normal CPU droplets fine. Let me know if you find any issues. |
also this catalog update is required to pass the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this amazing work @asaiacai ! This would be very helpful. Left some discussions ;)
Co-authored-by: Tian Xia <[email protected]>
Co-authored-by: Tian Xia <[email protected]>
@cblmemo smoke tests are passing on my end. the catalog PR should fix the CI failures. |
Thanks! QQ: Which catalog PR should I merge? Both skypilot-org/skypilot-catalog#83 and skypilot-org/skypilot-catalog#103? Also, just want to make sure, does the CI passed in your side when merging the above mentioned catalog PRs? |
only skypilot-org/skypilot-catalog#103 pushed an update to the |
Just curious, why Also, I think there is other cloud that has no T4 instance. Could you help check why the original test works for them but not $ sky show-gpus T4 --cloud fluidstack
Resources 'T4' not found on Fluidstack. To show available accelerators, run: sky show-gpus --all |
sorry for the back and forth here. The catalog was missing some instances with 32GB capability, which I just added to the catalog PR only skypilot-org/skypilot-catalog#103 I reverted
|
Thanks @asaiacai ! Just merged the catalog PR. Re-running unittest now and after it passed it should be ready to go! |
This adds digital ocean droplets to the sky.
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py --do