[k8s] Fix --purge not cleaning up cluster in stale k8s context
#4514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
reviewed
Dec 30, 2024
sky/backends/cloud_vm_ray_backend.py
Outdated
Comment on lines
4230
to
4231
| raise RuntimeError(f'Instance {node_id} in unexpected ' | ||
| 'state {node_status}.') |
There was a problem hiding this comment.
Would it be possible to have the purge check here instead, so that we can correctly print out some warnings for the clusters not correctly cleaned up even when --purge is specified.
There was a problem hiding this comment.
Ah yeah good point, updated the purge condition checks
Michaelvll
approved these changes
Jan 6, 2025
cg505
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue reported here: #2807 (comment)
sky down --purgenow works again even with stale or invalid context.Tested (run the relevant ones):
bash format.shsky local up; sky launch -c test --cloud kubernetes -- echo hi; mv ~/.kube/config ~/.kube/config.bak; sky down --purge test