Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add image_id doc in task YAML for OCI #4526

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

HysunHe
Copy link
Contributor

@HysunHe HysunHe commented Jan 3, 2025

doc for image_id for OCI.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@HysunHe
Copy link
Contributor Author

HysunHe commented Jan 3, 2025

@cblmemo This is the doc for image_id description for OCI of the task YAML. Could you help review it as well.

Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HysunHe ! LGTM.

docs/source/reference/yaml-spec.rst Outdated Show resolved Hide resolved
@cblmemo cblmemo merged commit e4939f9 into skypilot-org:master Jan 6, 2025
19 checks passed
@HysunHe HysunHe deleted the patch-1 branch January 6, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants