Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] OCI: advanced configuration & add vcn_ocid #4531

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

HysunHe
Copy link
Contributor

@HysunHe HysunHe commented Jan 4, 2025

This is the doc for:

  1. Some suggested changes for OCI advanced configuration
  2. added vcn_ocid ( PR [OCI] Support reuse existing VCN for SkyServe #4530 )

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@HysunHe HysunHe changed the title [docs] OCI: advanced configuration - add vcn_ocid configuration [docs] OCI: advanced configuration & add vcn_ocid Jan 4, 2025
@HysunHe
Copy link
Contributor Author

HysunHe commented Jan 4, 2025

@cblmemo doc for #4530

@cblmemo
Copy link
Collaborator

cblmemo commented Jan 6, 2025

Is it ready to merge? I noticed the second bullet point in the pr description is not added yet.

@HysunHe
Copy link
Contributor Author

HysunHe commented Jan 6, 2025

Is it ready to merge? I noticed the second bullet point in the pr description is not added yet.

Yeah, but it has dependancy on PR #4530

@cblmemo cblmemo merged commit 0e14982 into skypilot-org:master Jan 6, 2025
19 checks passed
@HysunHe HysunHe deleted the patch-2 branch January 6, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants