Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more fix of smoke tests #4548

Open
wants to merge 55 commits into
base: master
Choose a base branch
from

Conversation

zpoint
Copy link
Collaborator

@zpoint zpoint commented Jan 9, 2025

  • fix smoke tests bug #4492 is a prerequisite. Review and merge that PR first, then proceed to review this PR.
  • sky serve tests fix
  • separate the serve tests based on parameters to different buildkite agent, example: separate test_skyserve_new_autoscaler_update[rolling] and test_skyserve_new_autoscaler_update[blue_green]
  • Align the buildkite command with pytest: now use args to pass the command transparently to pytest, example:
    • /somke-test --aws
    • /somke-test --managed-jobs --aws
    • /somke-test --serve
    • /somke-test --aws -k test_nonexistent_bucket

^ The last one use -k filter to only trigger test name contains: test_nonexistent_bucket, we can trigger one test with -k option

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@zpoint
Copy link
Collaborator Author

zpoint commented Jan 9, 2025

/smoke-tests

@zpoint
Copy link
Collaborator Author

zpoint commented Jan 13, 2025

/smoke-test

@zpoint
Copy link
Collaborator Author

zpoint commented Jan 14, 2025

/quicktest-core

@zpoint
Copy link
Collaborator Author

zpoint commented Jan 14, 2025

/smoke-test managed_jobs

@zpoint
Copy link
Collaborator Author

zpoint commented Jan 15, 2025

/quicktest-core

@Michaelvll Michaelvll mentioned this pull request Jan 15, 2025
9 tasks
@zpoint zpoint requested a review from Michaelvll January 17, 2025 14:32
@zpoint
Copy link
Collaborator Author

zpoint commented Jan 18, 2025

/smoke-test

from smoke_tests.test_mount_and_storage import TestStorageWithCredentials

# isort: off
from smoke_tests.test_mount_and_storage import (TestStorageWithCredentials as
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename it so that it does not start with 'test' and will not be triggered twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant