[OCI]: Storage: support buckets from different region #4554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cblmemo Added this enhancement for the OCI storage support. Could you please help review it? Thanks~ |
Co-authored-by: Tian Xia <[email protected]>
cblmemo
reviewed
Jan 14, 2025
cblmemo
reviewed
Jan 15, 2025
|
Thanks @HysunHe ! LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an enhancement of OCI cloud storage support.
Before this change, the region the bucket belongs to is restricted to be same as the region in the OCI config file. This becomes the default setting if no region specified with this enhancement.
With this change, we can specify the region with the bucket name in the source or name attribute.
oci://<bucket_name> --> oci://<bucket_name>@
sky launch -c teststore ./examples/oci/dataset-upload-and-mount.yaml
sky launch -c teststore ./examples/oci/dataset-mount.yaml
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_nameconda deactivate; bash -i tests/backward_compatibility_tests.sh