[Core] Restore Autostop Settings on Start #8022
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lloyd-brown
requested review from
SeungjinYang,
kevinmingtarja and
rohansonecha
Collaborator
Author
|
/smoke-test |
lloyd-brown
removed request for
SeungjinYang,
kevinmingtarja and
rohansonecha
Collaborator
Author
|
/smoke-test -k test_autostop_wait_for_jobs --aws |
Collaborator
Author
|
/smoke-test |
lloyd-brown
requested review from
SeungjinYang,
kevinmingtarja and
rohansonecha
Collaborator
Author
|
/smoke-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR if a user launched a cluster with autostop enabled, the cluster became
STOPPEDbecause of autostop, and the user ransky startto bring the cluster back up the cluster would not retain its original autostop settings and would run forever. Given that the configuration for the cluster has not changed the user should expect the cluster to have autostop still enabled after runningsky start.This PR adds in this functionality by querying the cluster table for the autostop settings on start and using them when starting the cluster. I added a smoke test to ensure we maintain this functionality in the future.
Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)