Issue #109 unique key for an arrays of json objects#177
Open
GooDGreY wants to merge 1 commit intoskyscreamer:masterfrom
Open
Issue #109 unique key for an arrays of json objects#177GooDGreY wants to merge 1 commit intoskyscreamer:masterfrom
GooDGreY wants to merge 1 commit intoskyscreamer:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also had the same problem, as people in issue#109.
For example with json like this:
And custom comparator like this:
So "created_at" should be ignored, but AbstractComparator makes decision to use "created_at" as a unique key, when comparing elements in an array, so assertion fails. I fixed it, making it possible to pass unique key name as a parameter. For the example above, I would need to pass "booking_id" as a unique key for correct assertion