Custom visibility timeout, updated #112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To add custom visibility timeout for each message in SQS queue
Add custom visibility timeout to each message in SQS queue.You can set the value of visibilityTimeoutOnReset in spring configuration. Value is in seconds.
To set custom visibility timeout for each message in SQS queue.
Made changes as per your suggestions.
Made changes as per your suggestions. Created a new constructor.
Made changes as per your suggestions. I was not able to set visibilitytimeout as final as it was causing error in your current method-
protected AbstractSQSConnector(long receiveCheckIntervalMs, boolean isAsync)
{
_receiveCheckIntervalMs = receiveCheckIntervalMs;
_isAsync = isAsync;
}
removed unwanted constructor.
Removed BLANK_STRING as you suggested. I have kept the if conditions as sometimes it throws an exception "Unable to reset visibility timeout as receipthandle does not exist in queue" even if the message is there in the queue.
Correction made to if conditions for visibility timeout.
Made changes as per your suggestions. Created my own constructor.
Made changes as per your suggestions.
As per your suggestions I have made changes. Created a final variable.
Here I made _amazonSQS and _amazonSNS non final to implement the cut-paste anti pattern. So i created a private method to initialize the connection and created my own constructor as you suggested.
Initialized _visibilityTimeoutOnReset with default value.
Made changes as per your suggestions.
Added this() to second constructor and reverted the variables to final.
Removed the if check for receipt handle as you suggested. But now i get the exception.
# Conflicts: # nevado-jms/src/main/java/org/skyscreamer/nevado/jms/connector/amazonaws/AmazonAwsSQSConnectorFactory.java Signed-off-by: Aleksei Balan <abalanonline@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased fork of tejas1990
Recent version of aws sdk
Minor race conditions fixes