Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SAAA-13282 - Casting via Airplay is not working for iOS devices and user gets a Throbber with Black Screen #102

Conversation

venBharathManjunath
Copy link

@venBharathManjunath venBharathManjunath commented Jul 1, 2024

Fixes issue (TheWidlarzGroup#3411) with play content on airplay which is having Fairplay DRM. It is a patch fix since we are using 6.0.0-aplha-7, The issue is permanently addressed in v6.0.0
TheWidlarzGroup#3578

Thanks for opening a PR!
Since this is a volunteer project and is very active, anything you can do to reduce the amount of time needed to review and merge your PR is appreciated.
The following steps will help get your PR merged quickly:

Update the documentation

If you've added new functionality, update the README.md with an entry for your prop or event.
The entry should be inserted in alphabetical order.

Update the changelog

After you open the PR, update the CHANGELOG.md file with an entry pointing to your PR.

Provide an example of how to test the change

If the PR requires special testing setup provide all the relevant instructions and files. This may include a sample video file or URL, configuration, or setup steps.

Focus the PR on only one area

Testing multiple features takes longer than isolated changes and if there is a bug in one feature, prevents the other parts of your PR from getting merged until it gets fixed.
If you're touching multiple different areas that aren't related, break the changes up into multiple PRs.

Describe the changes

Add a note describing what your PR does. If there is a change to the behavior of the code, explain why it needs to be updated.

1000013471.mp4

@venBharathManjunath venBharathManjunath merged commit 2a40b51 into master-mobile Jul 2, 2024
2 checks passed
@MehmoodArib
Copy link

Thanks guys this solves the issue but the next challenge is while changing the video the next video didn't play it's again a blank screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants