Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dead code in harness to eliminate warnings #114

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

billonahill
Copy link
Contributor

Without this, warnings are emitted until users get late in week 2.

warning: function `compaction_bench` is never used
   --> mini-lsm-starter/src/tests/harness.rs:221:8
    |
221 | pub fn compaction_bench(storage: Arc<MiniLsm>) {
    |        ^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

warning: function `check_compaction_ratio` is never used
   --> mini-lsm-starter/src/tests/harness.rs:283:8
    |
283 | pub fn check_compaction_ratio(storage: Arc<MiniLsm>) {
    |        ^^^^^^^^^^^^^^^^^^^^^^

warning: function `dump_files_in_dir` is never used
   --> mini-lsm-starter/src/tests/harness.rs:413:8
    |
413 | pub fn dump_files_in_dir(path: impl AsRef<Path>) {
    |        ^^^^^^^^^^^^^^^^^

warning: `mini-lsm-starter` (lib test) generated 3 warnings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant