Skip to content

Conversation

@LinusU
Copy link

@LinusU LinusU commented Oct 8, 2025

Summary

This adds support for aborting in-flight requests, using the standardized AbortSignal

Fixes #1761

I've designed this as an additional parameter instead of mixing it with the body of the specific endpoint. I believe that this is a sounder approach as there will never be any conflicts, and it also avoids the current problem of token also being present in the request body as well as in the header when specified this way.

Requirements (place an x in each [ ])

@salesforce-cla
Copy link

salesforce-cla bot commented Oct 8, 2025

Thanks for the contribution! Before we can merge this, we need @LinusU to sign the Salesforce Inc. Contributor License Agreement.

@LinusU LinusU mentioned this pull request Oct 8, 2025
7 tasks
@LinusU
Copy link
Author

LinusU commented Oct 8, 2025

@salesforce-cla signed ✅

@zimeg zimeg closed this Oct 16, 2025
@zimeg zimeg reopened this Oct 16, 2025
@zimeg zimeg added semver:minor pkg:web-api applies to `@slack/web-api` labels Oct 16, 2025
@zimeg
Copy link
Member

zimeg commented Oct 16, 2025

Hey @LinusU! 👋 Thanks so much for sending this contribution in 👾 ✨

At the moment we're exploring another approach of a custom fetch attribute as an option to the WebClient alongside efforts of #2359.

I don't have more to share for @slack/web-api at the moment, but an example from @slack/webhook might resemble:

import { IncomingWebhook } from "@slack/webhook";
import { ProxyAgent, fetch as undiciFetch } from "undici";
const url = process.env.SLACK_WEBHOOK_URL;
/**
* Configure your proxy agent here
* @see {@link https://undici.nodejs.org/#/docs/api/ProxyAgent.md}
*/
const proxyAgent = new ProxyAgent({
uri: new URL("http://localhost:8888"),
proxyTls: {
signal: AbortSignal.timeout(400),
},
});
/**
* Implement a custom fetch adapter
* @type {typeof globalThis.fetch}
* @see {@link https://undici.nodejs.org/#/docs/api/Fetch.md}
*/
const myFetch = async (url, opts) => {
return await undiciFetch(url, {
...opts,
dispatcher: proxyAgent,
});
};
// Initialize with the custom fetch adapater and proxy
const webhook = new IncomingWebhook(url, {
fetch: myFetch,
});
// Sending this webhook will now go through the proxy
(async () => {
await webhook.send({
text: "I've got news for you...",
});
})();

Let's keep this open while that's explored, but I'm curious if the fetch approach might also be suitable for you?

@LinusU
Copy link
Author

LinusU commented Oct 16, 2025

Hey @zimeg, thanks for taking a look at this! 👋

[...] but I'm curious if the fetch approach might also be suitable for you?

I would love for this package to be based on fetch instead of Aaxios, and I took special care when writing this to not expose any Axios-specific behaviour (e.g. that is why I do the little dance to throw the correct error, instead of the Axios-specific cancelled error). So this should pair up great together with the fetch move!

With that said, I do not think that being able to pass in a custom fetch-function would solve the problem here. We are using AbortSignals across large parts of our app, not just as a tool to set a specific timeout on http requests.

I need to be able to pass signal individually to each api call, not at the creation of WebClient.


Side note: the example you linked will cancel every single request made 400 milliseconds after the ProxyAgent was constructed, not after each request has ran for 400ms?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:signed pkg:web-api applies to `@slack/web-api` semver:minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please support AbortSignal

2 participants