-
Notifications
You must be signed in to change notification settings - Fork 680
Add support for AbortSignal #2403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for the contribution! Before we can merge this, we need @LinusU to sign the Salesforce Inc. Contributor License Agreement. |
|
@salesforce-cla signed ✅ |
|
Hey @LinusU! 👋 Thanks so much for sending this contribution in 👾 ✨ At the moment we're exploring another approach of a custom fetch attribute as an option to the I don't have more to share for node-slack-sdk/packages/webhook/README.md Lines 95 to 133 in 56a6183
Let's keep this open while that's explored, but I'm curious if the |
|
Hey @zimeg, thanks for taking a look at this! 👋
I would love for this package to be based on fetch instead of Aaxios, and I took special care when writing this to not expose any Axios-specific behaviour (e.g. that is why I do the little dance to throw the correct error, instead of the Axios-specific cancelled error). So this should pair up great together with the fetch move! With that said, I do not think that being able to pass in a custom fetch-function would solve the problem here. We are using AbortSignals across large parts of our app, not just as a tool to set a specific timeout on http requests. I need to be able to pass Side note: the example you linked will cancel every single request made 400 milliseconds after the |
Summary
This adds support for aborting in-flight requests, using the standardized
AbortSignalFixes #1761
I've designed this as an additional parameter instead of mixing it with the body of the specific endpoint. I believe that this is a sounder approach as there will never be any conflicts, and it also avoids the current problem of
tokenalso being present in the request body as well as in the header when specified this way.Requirements (place an
xin each[ ])