test(logger): use included test runner dependencies #2425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimeg
requested review from
WilliamBergamin,
hello-ashleyintech,
mwbrooks and
vegeris
zimeg
added
semver:patch
tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2425 +/- ##
=======================================
Coverage 93.02% 93.02%
=======================================
Files 40 40
Lines 11124 11124
Branches 713 713
=======================================
Hits 10348 10348
Misses 764 764
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
WilliamBergamin
approved these changes
Nov 4, 2025
Comment on lines
-45
to
-51
| "@types/chai": "^4.3.5", | ||
| "@types/mocha": "^10.0.1", | ||
| "c8": "^10.1.2", | ||
| "chai": "^4.3.8", | ||
| "mocha": "^11.0.1", | ||
| "mocha-junit-reporter": "^2.2.1", | ||
| "mocha-multi-reporters": "^1.5.1", |
|
@WilliamBergamin I share the excitement here! These packages have been so kind to us, but I'm hoping we can reduce dependencies and updates needed going forward 🫡 Making similar updates in adjacent packages remains an interesting exercise I think! |
|
🏷️ This is also for #2359! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the following development dependencies to prefer the included
nodetest runner to replace #2351:@types/chai@types/mochac8chaimochamocha-junit-reportermocha-multi-reporterssinon🔗 https://nodejs.org/api/test.html
Requirements