Debug server file watching issues#130
Merged
Merged
Conversation
Ensure we always send server logs to the (redirected) STDIO and use the same file handle for stdio and stderr so that they write to the same offset. Also add an integration test to verify the server recovers from changes during analysis. Sadly this passes so it isn't yet the smoking gun we're hoping for.
The hakana server integration tests rely on watchman, but the native ubuntu package is too old and thus incompatible. Install a slightly less outdated version from upstream releases instead.
mszabo-wikia
force-pushed
the
debug-watch-issues
branch
from
0acad16 to
15b6e45
Compare
mszabo-wikia
commented
Apr 27, 2026
| eval $(opam env) | ||
| - name: Install watchman | ||
| run: | | ||
| curl -L --output watchman.deb https://github.com/mszabo-wikia/watchman/releases/download/v0.1.3-testing/watchman_ubuntu24.04_v0.1.3-testing.deb |
Collaborator
Author
There was a problem hiding this comment.
I have the only prepackaged watchman for Noble...
junoatwork
approved these changes
Apr 28, 2026
| config_path: Some(config_path.to_str().unwrap().to_string()), | ||
| plugins: vec![], | ||
| header: "".to_string(), | ||
| chaos_monkey: Some(Arc::new(move || { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure we always send server logs to the (redirected) STDIO and use the same file handle for stdio and stderr so that they write to the same offset.
Also add an integration test to verify the server recovers from changes during analysis. Sadly this passes so it isn't yet the smoking gun we're hoping for.