Remove timezone to avoid timestamp in the future#14
Closed
iosoftgame wants to merge 1 commit intoslashequip:mainfrom
Closed
Remove timezone to avoid timestamp in the future#14iosoftgame wants to merge 1 commit intoslashequip:mainfrom
iosoftgame wants to merge 1 commit intoslashequip:mainfrom
Conversation
Owner
|
@iosoftgame would something like this work for you; IIRC Segment can get a little funny about timezone and how it's formatted, ideally the package would always be sending in UTC for consistency. This change would set the timezone and shift the time as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use a different timezone than UTC in Laravel (UTC+2), which makes the Segment implementation fail upon transfer to destinations because of "dates in the future" due to timezone confusion.
As DateTime automatically has UTC as default Timezone, removing this line of code should use the default Timezone of the Laravel project.