Skip to content

Ensure that peer deps are externalized #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ikovic merged 2 commits into from
Apr 1, 2025
Merged

Ensure that peer deps are externalized #325

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23a4483
Ensure that peer deps are externalized
ikovic Apr 1, 2025
9beac19
Upgrade the ubuntu image in the CI due to brownout
ikovic Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nine-rats-judge.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@slashid/react": patch
---

Properly externalize deps
11 changes: 9 additions & 2 deletions packages/react/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import { resolve } from "node:path";
import { defineConfig } from "vite";
import { config } from "./vite.shared";

import * as packageJson from "./package.json";

export default defineConfig({
...config,
build: {
Expand All @@ -11,8 +13,13 @@ export default defineConfig({
fileName: `main`,
},
rollupOptions: {
// these must appear exactly as imported => having react here won't prevent react/jsx-runtime being bundled, so it must be explicit
external: ["react", "react/jsx-runtime", "react-dom", "react-dom/client"],
external: [
// include all the keys from peerDependencies by default
...Object.keys(packageJson.peerDependencies),
// these must be specified explicitly as they are not matched by react and react-dom from peer deps
"react/jsx-runtime",
"react-dom/client",
],
},
sourcemap: true,
},
Expand Down
Loading