Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unary rules #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Unary rules #6

wants to merge 1 commit into from

Conversation

davidweichiang
Copy link

Grammar.writeData was printing out grammars with rules that sum to more than one. This was apparently for two reasons:

  • It was intentionally printing out the max-closed unary rules instead of the real unary rules. But (IMO) it should print out the real rules because it's possible to recompute the max-closed rules from the real rules but not vice versa.
  • Grammar.computePairsOfUnaries had a line that was adding the sum-closed unary rules to the set of real unary rules.

@davidweichiang
fix bug in Grammar.computePairsOfUnaries that caused some sum-closed …
752dcc5 
…unary rules to be added as real unary rules; change Grammar.writeData to write real unary rules instead of max-closed unary rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidweichiang