Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linking bug which causes a stack overflow on a thread when actors are bi-directionally linked #168

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

slawlor
Copy link
Owner

@slawlor slawlor commented Sep 21, 2023

Resolves #167

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 91.89% and project coverage change: +0.04% 🎉

Comparison is base (0761b8c) 78.91% compared to head (8a8b02c) 78.95%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
+ Coverage   78.91%   78.95%   +0.04%     
==========================================
  Files          49       49              
  Lines        8945     8977      +32     
==========================================
+ Hits         7059     7088      +29     
- Misses       1886     1889       +3     
Files Changed Coverage Δ
ractor/src/actor/tests/supervisor.rs 91.71% <88.88%> (-0.09%) ⬇️
ractor/src/actor/supervision.rs 97.77% <100.00%> (+0.27%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slawlor slawlor marked this pull request as ready for review September 22, 2023 00:43
@slawlor slawlor merged commit bb33d4f into main Sep 22, 2023
11 checks passed
@slawlor slawlor deleted the double_link_err branch September 22, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bidirectional linking can cause stack overflow on actor shutdown
1 participant