Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Erlang-inspired process group (pg) scopes #177

Merged
merged 17 commits into from
Nov 11, 2023
Merged

Add Erlang-inspired process group (pg) scopes #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1da7ab0
Add the concept of scopes
leonqadirie Oct 11, 2023
b7b6843
Fix comments
leonqadirie Oct 11, 2023
b23ddd7
Outline the interface and add TODOs
leonqadirie Oct 11, 2023
650948b
Outline of tests to write or change
leonqadirie Oct 13, 2023
2f27fb3
Use Strings for `Scope` and add them to monitor
leonqadirie Oct 13, 2023
acf39fc
Reworked interfaces of tests to write and change
leonqadirie Oct 14, 2023
d2168bf
Added and changed tests to define new pg interface
leonqadirie Oct 14, 2023
ec6fb90
Added logic to new interface
leonqadirie Oct 14, 2023
a353e22
Rework global monitoring
leonqadirie Oct 14, 2023
81d546f
Add missing tests
leonqadirie Oct 14, 2023
9ce2577
Renamed functions for more consistent interface
leonqadirie Oct 14, 2023
149d870
Rename functions and deduplicate code
leonqadirie Oct 19, 2023
ee3a2c8
Deduplicate groups in `which_groups()`
leonqadirie Oct 19, 2023
c29efc1
Keep the protobuf spec backwards compatible
leonqadirie Oct 19, 2023
75f3775
Change identifying tuple to proper type
leonqadirie Oct 19, 2023
0abef7c
More idiomatic use of `map`s and `filter_map`s
leonqadirie Nov 4, 2023
7b1ee20
Fixed and improved documentation
leonqadirie Nov 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ractor/src/actor/messages.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,12 @@
write!(f, "Actor panicked {actor:?} - {panic_msg}")
}
SupervisionEvent::ProcessGroupChanged(change) => {
write!(f, "Process group {} changed", change.get_group())
write!(
f,
"Process group {} in scope {} changed",
change.get_group(),
change.get_scope()
)

Check warning on line 154 in ractor/src/actor/messages.rs

View check run for this annotation

Codecov / codecov/patch

ractor/src/actor/messages.rs#L149-L154 

Added lines #L149 - L154 were not covered by tests
}
#[cfg(feature = "cluster")]
SupervisionEvent::PidLifecycleEvent(change) => {
Expand Down
3 changes: 3 additions & 0 deletions ractor/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,9 @@ pub type ActorName = String;
/// A process group's name, equivalent to an [Erlang `atom()`](https://www.erlang.org/doc/reference_manual/data_types.html#atom)
pub type GroupName = String;

/// A scope's name, equivalent to an [Erlang `atom()`](https://www.erlang.org/doc/reference_manual/data_types.html#atom)
pub type ScopeName = String;

/// Represents the state of an actor. Must be safe
/// to send between threads (same bounds as a [Message])
pub trait State: std::any::Any + Send + 'static {}
Expand Down
Loading
Loading