Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the tokio dependencies to support an older version #291

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

slawlor
Copy link
Owner

@slawlor slawlor commented Nov 26, 2024

Usage of JoinSet.join_all() was introduced in Tokio 1.40 which is still quite new. This change allows using an older version of tokio (down to ~1.30) which we specify in the crate deps.

@slawlor slawlor marked this pull request as ready for review November 26, 2024 16:33
@slawlor slawlor merged commit 1949d92 into main Nov 26, 2024
11 checks passed
@slawlor slawlor deleted the tokio_version branch November 26, 2024 16:41
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.30%. Comparing base (73b62e7) to head (dbdb8ba).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ractor/src/actor/supervision.rs 40.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
- Coverage   81.34%   81.30%   -0.05%     
==========================================
  Files          60       60              
  Lines       10848    10856       +8     
==========================================
+ Hits         8824     8826       +2     
- Misses       2024     2030       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant