Skip to content

Fix: Handle NamedTemporaryFile correctly for Windows #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StructuralWizard wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Handle NamedTemporaryFile correctly for Windows #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions code_video/code_walkthrough.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import os
from tempfile import NamedTemporaryFile
from typing import List
from typing import Optional
Expand Down Expand Up @@ -105,7 +106,11 @@ def __init__(
else:
code = code[start_line - 1 :]

with NamedTemporaryFile(suffix=f".{extension}") as f:
f.writelines([line.encode() for line in code])
f.flush()
super().__init__(f.name, line_no_from=start_line, **kwargs)
temp_file = NamedTemporaryFile(suffix=f".{extension}", delete=False)
try:
temp_file.writelines([line.encode() for line in code])
temp_file.flush()
temp_file.close() # Close the file before super().__init__
super().__init__(temp_file.name, line_no_from=start_line, **kwargs)
finally:
os.remove(temp_file.name) # Ensure deletion