namespace changes (WIP) #3
Conversation
slevis-lmwg
left a comment
slevis-lmwg
left a comment
There was a problem hiding this comment.
@rgknox this looks good to me. I can approve when we resolve my two questions.
| use PRTGenericMod, only : fates_cnp | ||
| use PRTGenericMod, only : carbon_only | ||
| use PRTGenericMod, only : carbon_nitrogen_phosphorus |
There was a problem hiding this comment.
Here you added a use statement for carbon_only that does not get used. If you did that intentionally, I'm fine with it. Otherwise, I would delete the unnecessary line.
There was a problem hiding this comment.
@rgknox while you resolve the other one, pls see what you think about this comment as well, though this one is just a case of an unnecessary line, so no big deal if it stays.
There was a problem hiding this comment.
...and once these comments are resolved, this PR can be merged.
|
|
||
| ! initialize some values | ||
| hlm_parteh_mode = fates_c_only | ||
| hlm_parteh_mode = carbon_nitrogen_phosphorus |
There was a problem hiding this comment.
This replacement is incorrect, unless the fates_c_only here was incorrect to begin with.
There was a problem hiding this comment.
@rgknox pls correct me if I'm wrong: I think you said you would address this one, so I will wait.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
|
Though I also do not want to forget the two pending questions that I posted above: |
2 participants
This fates side PR is paired with ctsm side PR slevis-lmwg/ctsm#19