feat: UI interaction polish + SessionView cleanup - #68
Open
slicenferqin wants to merge 5 commits into
Open
Conversation
added 5 commits
June 1, 2026 15:57
…mponents Phase 3 — Retire user-visible fallback: - Remove sessionUiV2Enabled toggle from Settings - Remove sessionUiV2Enabled from useSettingsStore - MainPane always renders SessionShell (no conditional switch) Phase 4 — Replace legacy tests: - Delete session-view.test.tsx (2440 lines of legacy SessionView tests) - Remove dead SessionView mocks from 3 test files Phase 5 — Delete legacy UI: - Delete SessionView.tsx (5485 lines) - Remove SessionView re-export from sessions/index.ts - Delete 10 orphaned session components: ModeToggle, CodexFastToggle, FileMentionPopover, IndeterminateProgressBar, QuestionPrompt, QueuedIndicator, QueuedMessageBubble, QueuedMessagesBar, SessionTaskTracker, SessionTokenSaverBanner - Delete 11 associated test files Naming cleanup: - Rename session-view-registry.ts → session-scroll-registry.ts - Rename SessionViewState → ScrollAnchorState - Rename all registry functions (get/set/update/remove/reset*) - Keep storage key 'xuanpu:session-view-registry' for backward compat - Update 5 test files + 2 source files for new names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
cleanup: complete SessionView deprecation + remove orphaned legacy componentsdocs: plan provider-neutral naming cleanuprefactor: decouple session hq from legacy SessionViewfix: enable 1m claude context modelsfix(codex): stabilize session errors and xuanpu toolsTest plan