Repository navigation
fix(geom): a flat top pushes down along a round wall - #2341
Open
subydoo-ci[bot] wants to merge 1 commit into
Open
subydoo-ci[bot] wants to merge 1 commit into
subydoo-ci[bot] wants to merge 1 commit into
Conversation
Pushing the top of a cylinder, or of a slot with round ends, down on the mesh was refused as unsafe at mesh storage precision (intersecting faces). Two things caused it. The face's normal comes from one of its triangles, and a kernel's tessellation leaves a round top a few ulps off flat, so the normal leans a few 1e-15 off the axis. The cutting prism stepped along that normal from each rim point, its walls crossed the body's walls at that tiny angle, and the cut left long crossing needles. The prism now steps along the body's own wall edge where one runs along the normal. The prism's walls also follow the chords between the rim points, and a wall is often not exactly on them: the kernel leaves points between the rims a few ulps off those planes, or, on a round wall, on the bulge past the chords. The cut then left crossing needles or flaps a few microns thick. When all the body has above the new level is the face and its walls, the walls are not exactly on the prism's, and nothing stands more than 0.05 mm outside the face's outline, the cut is now a slab over the whole body from that level up. Pulls, pushes whose walls lie exactly on the outline (a box, a bar), and pushes with other parts of the body above the new level use the prism as before. A box or a bar pushed down or pulled gives the same bytes as before. Signed-off-by: subydoo-ci[bot] <343861189+subydoo-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pushing a flat top down along a round wall on the mesh was refused as "unsafe at mesh storage precision (intersecting faces)". It happened on the top of a cylinder, and on a slot with round ends once its walls had points between the rims.
For users (against main)
slicerx_geom_push_pull1.5.1 pushes the top of a round post or of a slot with round ends down. Before, it was refused.What changed
Testing
packages/geom/src/push.rs: a round post, a slot with round ends and a bar whose tops are a few ulps off flat, with 0, 1 and 3 rows of wall points between the rims, pushed down 2 and pulled 2; a round post pushed down beside a taller one; a plate pushed down around a post standing in its top; a block beside a post just inside and just past the 0.05 mm bound. The first four fail on main.brep_paritygains "push a round top" (a 20 x 10 cylinder down 2), which fails on main. Its push cases also pass with a finer exact tessellation (a 0.5 to 4 mm side limit).packages/mcp/test/array-pieces.test.tspinsslicerx_geom_arrayat 1.10.1, moved with its bump.Integrators:
slicerx_geom_push_pull1.5.1 answers a push down along a round wall with the pushed part instead of a refusal.slicerx_geom_mirror1.7.1 andslicerx_geom_array1.10.1 repeat a push step, andslicerx_design_edit_step1.9.1 runs one again with a new distance, so they answer the same way. Nothing changes in a request.slicerx_design_undoandslicerx_design_redoare not bumped: they replay steps that were already accepted.