Skip to content

A looked-up height measured from the keel or the ground sets where a part's top sits, not the part's own height - #2344

Merged
subydoo-ci[bot] merged 1 commit into
mainfrom
fix/reference-heights
Nov 15, 2026
Merged

subydoo-ci[bot] merged 1 commit into
mainfrom
fix/reference-heights

Conversation

@subydoo-ci

@subydoo-ci subydoo-ci Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

What this changes

A size lookup can return a height measured from a reference, such as "Funnel height above keel, 53.3 m". A display plan that tied that figure to the funnel was refused: the funnel "has no size named height above keel", so tie the real size to one of its own sizes (diameter, height). The only way through was to call 53.3 m the funnel's own height. The plan's scale rule then made the funnel about three times too tall.

A height measured from a reference is read as where a part's top sits.

  • design.lookup_sizes tags such a size with from, the reference it's measured from: keel, base, ground, deck, sea level and so on. Its other fields are unchanged.
  • design.plan's real-size check holds a real row with such a size against the part's planned top where it stands: the top of what it stands on, plus its own height, at the plan's scale. It doesn't match the row to one of the part's own sizes.
  • The reference comes from the lookup's tag. A row with no tag, from an older lookup, a stated size or a client plan, is read from the size's name.

Where a part stands. A part stands on the feature its on names, or on the level below it in its tier list. A main body with no on stands at zero. Any other part with no on stands on the main body with the most bulk. A reference such as keel, base or ground is zero. A reference that names a planned part is that part's top. A plain deck or roof is the top of what the part stands on.

References a plan can't place keep today's behavior, because there's no height to check them against. These are a waterline or the sea, or a part the plan doesn't have.

What the model reads.

  • When such a row's top is off scale, the refusal begins: "real: Funnel's height above keel is where its top sits, not its own height: keep it as given, and the plan checks it against the top of Funnel where it stands". The existing off-scale line follows it.
  • design.plan's description of real adds: "A real size measured from a reference (above keel, above deck, above ground) gives where the part's top sits, not the part's own height."

Why

In a recorded session, the plan's funnels were right at 14 mm until this refusal. The plan sent after it tied 53.3 m to the funnel's own height and built funnels 42.6 mm tall. Its superstructure was regrouped in the same rewrite, and its lifeboats were dropped.

For users

A display model built from looked-up sizes keeps its parts in proportion when a source gives a height measured from the keel, the ground or a deck.

Integrators:

  • slicerx_design_lookup_sizes 1.2.0 (from 1.1.2), in the mimir tab: a found size measured from a reference carries from.
  • slicerx_design_plan 1.19.0 (from 1.18.0), in the mimir tab, and slicerx_design_put_plan 1.10.1 (from 1.10.0): a real size measured from a reference is checked against the part's planned top where it stands.

The change file is packages/mcp/changes/fix-reference-heights.md. TOOLS.md changes only in design.put_plan's version row, written by pnpm tools-doc.

Expectations changed

  • packages/mcp/test/real-lookup-read.test.ts: the found entry "Tower height above the roof" now carries from: 'roof'.
  • Version pins in design-check, plan-amend-kept-fields, plan-amend, plan-detail, plan-floors, plan-open-faces and plan-input-defaults tests.

How it was tested

New tests in packages/mcp/test/plan-reference-heights.test.ts (16):

  • The name parser: the forms it reads, such as "height above keel", "Height keel to top" and "above mean sea level". The names it leaves alone, such as "Length bow to stern" and "Distance from the shore".
  • Both new sentences are pinned word for word.
  • The lookup tags from, both through its reader and through the tool.
  • A recorded plan replayed with neutral names (a tower with a chimney, "Chimney height above base"):
    • With the chimney standing on the tower's body, its top is 30.8 mm against the 42.6 mm the real figure gives, so it's refused as off scale, with the new sentence and no "no size named" line.
    • With the chimney on a deck house on the body, it's taken, and the chimney keeps its 14 mm.
  • A row tagged from a reference that names the part's own height is held as a top.
  • A row with no tag, "height above keel", is read from its name.
  • Tops for a part standing on a body, on a house on it and on a lookout, and for a part with no on.
  • References named by a planned part, and by a deck.
  • A waterline and a part the plan doesn't have keep today's refusal.

On macOS, on this tip:

  • pnpm -r typecheck passed in every workspace.
  • packages/mcp tests that mention a plan, a real size, a lookup or scale: 1,279 passed and 191 skipped.
  • packages/pilot: 1,755 passed and 33 skipped.
  • packages/app (whole suite): 714 files, 5,935 passed and 180 skipped.
  • pnpm tools-doc --check, node scripts/fold-changes.mjs packages/mcp --check and node scripts/check-dashes.mjs on the changed files pass.

On Linux, on this tip:

  • Typecheck passed for contracts, mcp, pilot and app.
  • packages/pilot: 1,788 passed.
  • packages/app mimir suites: 964 passed and 23 skipped.
  • packages/mcp: 2,368 passed and 42 skipped.

Checklist

  • Commits follow Conventional Commits and are signed off (git commit -s)
  • pnpm lint, pnpm typecheck, pnpm test, cargo clippy, and cargo test pass
  • Tests added or updated
  • Screenshot or recording attached for UI changes
  • Docs updated if behavior or a public interface changed
  • MCP server changes: a file in packages/mcp/changes/, and no edit to packages/mcp/CHANGELOG.md or packages/mcp/TOOLS.md (a release writes both)
  • Any code from another project is credited, and its license is compatible with Apache-2.0
  • No secrets, keys, or private model files in the diff
  • AI tools helped with this change (name them here: ...), and I have read CONTRIBUTING-AI.md

…s where a part's top sits, not the part's own height

design.lookup_sizes tags each found size whose name measures a height from a reference with that reference in from. design.plan holds a real size measured from a reference against the planned top of its part where it stands (the top of what it stands on plus its own height) at the plan's scale, instead of refusing it for naming no size of the part. A part with no on stands on the main body with the most bulk. A reference the plan has no height for, such as a waterline, is read by the part's own sizes as before.

Signed-off-by: subydoo-ci[bot] <343861189+subydoo-ci[bot]@users.noreply.github.com>
@subydoo-ci subydoo-ci Bot added bug Something isn't working user-facing People using SlicerX will notice this; it goes in the release notes roadmap:cad Roadmap feature: cad integrators Changes what editions and integrations build against; the PR has an Integrators: line labels Nov 15, 2026
@subydoo-ci
subydoo-ci Bot added this pull request to the merge queue Nov 15, 2026
Merged via the queue into main with commit b8643eb Nov 15, 2026
160 checks passed
@subydoo-ci
subydoo-ci Bot deleted the fix/reference-heights branch November 15, 2026 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working integrators Changes what editions and integrations build against; the PR has an Integrators: line roadmap:cad Roadmap feature: cad user-facing People using SlicerX will notice this; it goes in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants