Repository navigation
A looked-up height measured from the keel or the ground sets where a part's top sits, not the part's own height - #2344
Merged
Conversation
…s where a part's top sits, not the part's own height design.lookup_sizes tags each found size whose name measures a height from a reference with that reference in from. design.plan holds a real size measured from a reference against the planned top of its part where it stands (the top of what it stands on plus its own height) at the plan's scale, instead of refusing it for naming no size of the part. A part with no on stands on the main body with the most bulk. A reference the plan has no height for, such as a waterline, is read by the part's own sizes as before. Signed-off-by: subydoo-ci[bot] <343861189+subydoo-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
A size lookup can return a height measured from a reference, such as "Funnel height above keel, 53.3 m". A display plan that tied that figure to the funnel was refused: the funnel "has no size named height above keel", so tie the real size to one of its own sizes (diameter, height). The only way through was to call 53.3 m the funnel's own height. The plan's scale rule then made the funnel about three times too tall.
A height measured from a reference is read as where a part's top sits.
from, the reference it's measured from: keel, base, ground, deck, sea level and so on. Its other fields are unchanged.Where a part stands. A part stands on the feature its
onnames, or on the level below it in its tier list. A main body with noonstands at zero. Any other part with noonstands on the main body with the most bulk. A reference such as keel, base or ground is zero. A reference that names a planned part is that part's top. A plain deck or roof is the top of what the part stands on.References a plan can't place keep today's behavior, because there's no height to check them against. These are a waterline or the sea, or a part the plan doesn't have.
What the model reads.
realadds: "A real size measured from a reference (above keel, above deck, above ground) gives where the part's top sits, not the part's own height."Why
In a recorded session, the plan's funnels were right at 14 mm until this refusal. The plan sent after it tied 53.3 m to the funnel's own height and built funnels 42.6 mm tall. Its superstructure was regrouped in the same rewrite, and its lifeboats were dropped.
For users
A display model built from looked-up sizes keeps its parts in proportion when a source gives a height measured from the keel, the ground or a deck.
Integrators:
slicerx_design_lookup_sizes1.2.0 (from 1.1.2), in the mimir tab: a found size measured from a reference carriesfrom.slicerx_design_plan1.19.0 (from 1.18.0), in the mimir tab, andslicerx_design_put_plan1.10.1 (from 1.10.0): a real size measured from a reference is checked against the part's planned top where it stands.The change file is packages/mcp/changes/fix-reference-heights.md. TOOLS.md changes only in design.put_plan's version row, written by
pnpm tools-doc.Expectations changed
from: 'roof'.How it was tested
New tests in packages/mcp/test/plan-reference-heights.test.ts (16):
from, both through its reader and through the tool.on.On macOS, on this tip:
pnpm -r typecheckpassed in every workspace.pnpm tools-doc --check,node scripts/fold-changes.mjs packages/mcp --checkandnode scripts/check-dashes.mjson the changed files pass.On Linux, on this tip:
Checklist
git commit -s)pnpm lint,pnpm typecheck,pnpm test,cargo clippy, andcargo testpasspackages/mcp/changes/, and no edit topackages/mcp/CHANGELOG.mdorpackages/mcp/TOOLS.md(a release writes both)