Skip to content

fix: 무한스크롤 할 때 lastGoalId부터 불러오기로 수정 #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bbbbooo merged 1 commit into from
Dec 29, 2024
Merged

fix: 무한스크롤 할 때 lastGoalId부터 불러오기로 수정 #158

bbbbooo merged 1 commit into from
Dec 29, 2024

Conversation

@soheeparklee
Copy link
Contributor

@soheeparklee soheeparklee commented Dec 29, 2024

#️⃣연관된 이슈

ex) #이슈번호, #이슈번호

📝작업 내용

lastGoalId 이후로 목표를 size수만큼 불러오도록 수정합니다.

스크린샷 (선택)

Screenshot 2024-12-29 at 11 48 28

💬리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메소드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

@soheeparklee soheeparklee requested a review from bbbbooo December 29, 2024 10:48
@soheeparklee soheeparklee linked an issue Dec 29, 2024 that may be closed by this pull request
목표 상세 페이지 무한스크롤 수정 #155
Closed
1 task
bbbbooo
bbbbooo approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@bbbbooo bbbbooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

@bbbbooo bbbbooo merged commit 5ec91d0 into develop Dec 29, 2024
1 check passed
@bbbbooo bbbbooo deleted the fix/goal-scroll branch December 29, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbbbooo bbbbooo bbbbooo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

목표 상세 페이지 무한스크롤 수정

3 participants

@soheeparklee @bbbbooo