Fixed constant spelling (fixes #67) #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a little resistant to removed the typo, as it could potentially break somebody's code if they update to the newer version of the library. The ideal thing to do would really be to raise a warning if this deprecated constant is used and define the 'correct' one. Here's a way to seemingly hack marking module constants as deprecated: http://erouault.blogspot.com/2014/11/hacking-python-module-constants.html, I'll need to play with it first before I implement in this library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed AC_TYPE_ADDDRESS to AC_TYPE_ADDRESS.