fix(happy-cli): unblock SDK messages while waiting for user input#843
Open
EricSeastrand wants to merge 1 commit intoslopus:mainfrom
Open
fix(happy-cli): unblock SDK messages while waiting for user input#843EricSeastrand wants to merge 1 commit intoslopus:mainfrom
EricSeastrand wants to merge 1 commit intoslopus:mainfrom
Conversation
The for-await loop in claudeRemote awaited nextMessage() synchronously, which blocked all SDK messages (background task completions, system notifications) from being forwarded to the phone until the user sent their next message. Switch to a non-blocking .then() pattern so the loop keeps iterating and forwarding events while waiting for input. Fixes head-of-line blocking reported in GitHub slopus#639. Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
for awaitloop inclaudeRemote()synchronously awaitsnextMessage()after receiving aresultmessage, which blocks the entire loop from iteratingnextMessage()to a non-blocking.then()pattern so the loop keeps forwarding SDK events while waitingThis is a complementary fix to PR #699 — that PR fixes head-of-line blocking in
OutgoingMessageQueue, this one fixes a separate blocking point upstream in theclaudeRemotemessage loop. Both contribute to the same symptom.Fixes #639
Test plan
sleep 12 && echo "BACKGROUND DONE"with parallel file writes)nextMessage()await🤖 Generated with Claude Code
via Happy