Yet another Tokio v1 PR#78
Merged
flosse merged 3 commits intoslowtec:masterfrom Jul 28, 2021
bootrecords:master
Merged
Conversation
updated env_logger dependency added some documentation on Response parameters fixed a few spelling issues
Member
|
@Tarnadas & @ivomurrell would you mind to have a look at this? |
Contributor
Author
|
@ColinFinck or @david-mcgillicuddy-moixa may also be interested, based on their recent comments on #72 |
Tarnadas
approved these changes
Jul 23, 2021
Contributor
Tarnadas
left a comment
Tarnadas
left a comment
There was a problem hiding this comment.
Thanks for picking up my prior work.
Unfortunately it was hard for me to find the time to do it myself.
The code changes look good.
Contributor
|
I tested it in my program and everything works. Thank you ! |
flosse
approved these changes
Jul 28, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the PR from @Tarnadas but with
tokio_serialadded back in as a dependency instead ofserial-iodue to its incoming Windows pipes support (from berkowski/tokio-serial#42 and earlier work).Also homogenized and expanded a bit of documentation for a little bit.
Works on my machine™ (actually semi-field-tested against a serial device from a Linux host and communications appear to work).
Reviews and eventual merge are welcome.
Closes #71 and #76