Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests do not create issues if the shim step fails #204

Open
5 of 29 tasks
ianlewis opened this issue Jun 6, 2023 · 0 comments
Open
5 of 29 tasks

Tests do not create issues if the shim step fails #204

ianlewis opened this issue Jun 6, 2023 · 0 comments
Assignees
@ianlewis
Labels
bug Something isn't working

Comments

@ianlewis
Copy link
Member

ianlewis commented Jun 6, 2023 •
edited
Loading

Most e2e tests check for needs.shim.outputs.continue == 'yes' but don't check if the shim job actually succeeded. We should create an issue if the shim step fails. This goes for the push or dispatch steps as well.

  • .github/workflows/e2e.container.push.branch1.default.slsa3.yml
  • .github/workflows/e2e.go.tag.main.config-ldflags-noassets.slsa3.yml
  • .github/workflows/e2e.container.tag.main.default.slsa3.yml
  • .github/workflows/e2e.container-based.tag.main.default.slsa3.yml
  • .github/workflows/e2e.go.tag.main.adversarial-asset-provenance.slsa3.yml
  • .github/workflows/e2e.generic.tag.main.assets.slsa3.yml
  • .github/workflows/e2e.go.push.branch1.config-ldflags.slsa3.yml
  • .github/workflows/e2e.go.tag.branch1.config-ldflags-assets.slsa3.yml
  • .github/workflows/e2e.go.release.main.config-ldflags-noassets.slsa3.yml
  • .github/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
  • .github/workflows/e2e.generic.push.branch1.default.slsa3.yml
  • .github/workflows/e2e.generic.tag.main.annotated.slsa3.yml
  • .github/workflows/e2e.go.release.main.config-ldflags-assets.slsa3.yml
  • .github/workflows/e2e.go.tag.main.adversarial-asset-binary.slsa3.yml
  • .github/workflows/e2e.nodejs.release.main.default.slsa3.yml
  • .github/workflows/e2e.container.tag.main.gcp-workload-identity.slsa3.yml
  • .github/workflows/e2e.container.tag.branch1.default.slsa3.yml
  • .github/workflows/e2e.nodejs.push.branch1.default.slsa3.yml
  • .github/workflows/e2e.go.tag.main.config-ldflags-assets-tag.slsa3.yml
  • .github/workflows/e2e.nodejs.create.main.default.slsa3.yml
  • .github/workflows/e2e.go.tag.main.config-ldflags-assets-prerelease-tag.slsa3.yml
  • .github/workflows/e2e.container.tag.main.registry-username-secret.yml
  • .github/workflows/e2e.generic.release.main.default.slsa3.yml
  • .github/workflows/e2e.generic.tag.branch1.default.slsa3.yml
  • .github/workflows/e2e.generic.tag.main.goreleaser-assets-multi-subjects.slsa3.yml
  • .github/workflows/e2e.go.workflow_dispatch.branch1.config-ldflags.slsa3.yml
  • .github/workflows/e2e.go.tag.main.config-ldflags-assets-draft-tag.slsa3.yml
  • .github/workflows/e2e.go.release.main.config-ldflags-assets-tag.slsa3.yml
  • .github/workflows/e2e.nodejs.tag.main.default.slsa3.yml
@ianlewis ianlewis added the bug Something isn't working label Jun 6, 2023
@ianlewis ianlewis self-assigned this Jun 8, 2023
@ianlewis ianlewis mentioned this issue Jun 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianlewis ianlewis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ianlewis