Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update go to 1.21 #738

Merged

Conversation

ramonpetgrave64
Copy link
Contributor

@ramonpetgrave64 ramonpetgrave64 commented Jan 18, 2024

Fixing the existing PR #498 to also change the github actions to use the go 1.21 sourced directly from go.mod.

...
Error: We were unable to automatically build your code. Please replace the call to the autobuild action with your custom build steps. Encountered a fatal error while running "/opt/hostedtoolcache/CodeQL/2.15.5/x64/codeql/go/tools/autobuild.sh". Exit code was 1 and error was: 2024/01/17 18:06:58 Autobuilder was built with go1.21.5, environment has go1.20.12
...

Also fixing some more lint checks about repeated strings

renovate-bot and others added 10 commits January 18, 2024 18:51
Signed-off-by: Mend Renovate <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
This reverts commit e8befa2.

Signed-off-by: Ramon Petgrave <[email protected]>
This reverts commit 0bc2c70.

Signed-off-by: Ramon Petgrave <[email protected]>
This reverts commit 8c346b8.

Signed-off-by: Ramon Petgrave <[email protected]>
@ramonpetgrave64 ramonpetgrave64 marked this pull request as ready for review January 18, 2024 19:05
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
This reverts commit f468545.

Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. There may be a rebase issue to fix before merging

@laurentsimon
Copy link
Contributor

Enabling auto-merge

@laurentsimon laurentsimon enabled auto-merge (squash) January 23, 2024 16:39
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
auto-merge was automatically disabled January 23, 2024 17:30

Head branch was pushed to by a user without write access

.github/workflows/pre-submit.lint.yml Show resolved Hide resolved
# TODO(2680): re-enable go-version-file
# go-version-file: "go.mod"
go-version: '1.20'
go-version-file: "go.mod"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the issue with using go-version-file before? I guess we fixed it in 1.9.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the issue was before, but using go-version-file instead of go-version lets use specify which version to use in only one place.

Copy link
Member

@ianlewis ianlewis Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I remember we fixed an issue with it and maybe that was in 1.9.0?
slsa-framework/slsa-github-generator#2661

But it looks like we haven't released that fix yet.
slsa-framework/slsa-github-generator@00c744f

.github/workflows/pre-submit.lint.yml Show resolved Hide resolved
.github/workflows/codeql-analysis.yml Outdated Show resolved Hide resolved
Signed-off-by: Ramon Petgrave <[email protected]>
@laurentsimon laurentsimon merged commit 74119b2 into slsa-framework:main Jan 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants