Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and test harbor #1588

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
2e115e6
Update harbor_argocd_appset.yaml
cloudymax Mar 1, 2025
8caf5fe
adding external secrets
cloudymax Mar 1, 2025
2d92acb
update external secret chart templates
cloudymax Mar 1, 2025
6bcc478
add more templates copied from gotosocial
cloudymax Mar 1, 2025
a2c79fc
more harbor specific changes
cloudymax Mar 1, 2025
5dc6fae
add redis config
cloudymax Mar 1, 2025
bbb057a
remove old appset
cloudymax Mar 1, 2025
7b1ead1
add backuos dir
cloudymax Mar 1, 2025
a46ca46
Apply suggestions from code review - fix gotosocial to harbor
jessebot Mar 1, 2025
3f26aff
change more harbor to gotosocial everywhere
jessebot Mar 1, 2025
e0715bb
Update harbor/external_secrets/templates/bitwarden/admin-credentials.…
jessebot Mar 1, 2025
bf05c04
update docs for harbor and clean up helm chart values
jessebot Mar 2, 2025
b9f3453
we should in fact use the admin password feature so adding that back …
jessebot Mar 2, 2025
449ce12
removing more unused stuff
jessebot Mar 2, 2025
0ce2a45
fix the harbor admin secrets parameter
jessebot Mar 2, 2025
dbf5174
add a reusable valkey helm chart for deploying valkey via a helm chart
jessebot Mar 2, 2025
4888124
fall back to using regular valkey to deploy valkey instead of helm chart
jessebot Mar 2, 2025
8843eea
update the valkey applicationset
jessebot Mar 2, 2025
5a37ae8
use the feature branch for external secrets and pvc until we merge
jessebot Mar 2, 2025
af6a0fd
fix the jobs, registry, and trivy PVCs
jessebot Mar 2, 2025
8545127
fix the valkey pvc
jessebot Mar 2, 2025
839524b
clean up our pvc creation for harbor
jessebot Mar 2, 2025
4cef6e1
switch to the bitnami chart for the main helm chart
jessebot Mar 2, 2025
f1a8eb3
generate registry credentials
jessebot Mar 2, 2025
fa83941
add registry credentials
jessebot Mar 2, 2025
4714f3e
add more trivvy params
jessebot Mar 2, 2025
d0a2ff8
update to the latest mastodon glitch soc version
jessebot Mar 7, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
we should in fact use the admin password feature so adding that back …
…to the secrets docs
jessebot committed Mar 2, 2025
commit b9f345306a0b6e6a46aab779645b9d8449f82dc6
2 changes: 1 addition & 1 deletion harbor/external_secrets/README.md
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@ A Helm chart for Harbor External Secrets using the Bitwarden ESO provider on Kub

| Key | Type | Default | Description |
|-----|------|---------|-------------|
| adminCredentialsBitwardenID | string | `""` | admin credentials - currently NOT in use |
| adminCredentialsBitwardenID | string | `""` | admin credentials |
| oidcCredentialsBitwardenID | string | `""` | OIDC Credentials |
| pgsqlCredentialsBitwardenID | string | `""` | postgres credentials |
| provider | string | `""` | Use external secrets. Set to bitwarden to use this chart. other providers may be supported in the future |
2 changes: 1 addition & 1 deletion harbor/external_secrets/values.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# -- Use external secrets. Set to bitwarden to use this chart. other providers may be supported in the future
provider: ""

# -- admin credentials - currently NOT in use
# -- admin credentials
adminCredentialsBitwardenID: ""

# -- smtp credentials

Unchanged files with check annotations Beta

size: 10Gi
## storageClass specifies the storage class name to be used for this pool
### Docs: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/docs/parameters.md

Check warning on line 75 in harbor/storage/minio_tenant/tenant_argocd_appset.yaml

In Solidarity / Inclusive Language

Match Found

Please consider an alternative to `master`. Possibilities include: `primary`, `main`, `leader`, `active`, `writer`
Raw output
/master/gi
storageClassName: local-path
## nodeSelector parameters for MinIO Pods. It specifies a map of key-value pairs. For the pod to be
## https://kubernetes.io/docs/tasks/tls/managing-tls-in-a-cluster
requestAutoCert: false
# https://github.com/minio/operator/blob/master/examples/kustomization/tenant-certmanager/certificates.yaml

Check warning on line 124 in harbor/storage/minio_tenant/tenant_argocd_appset.yaml

In Solidarity / Inclusive Language

Match Found

Please consider an alternative to `master`. Possibilities include: `primary`, `main`, `leader`, `active`, `writer`
Raw output
/master/gi
## Use certificates generated by cert-manager.
# externalCertSecret:
# - name: minio-tls
# type: cert-manager.io/v1
## MinIO features to enable or disable in the MinIO Tenant
## https://github.com/minio/operator/blob/master/docs/tenant_crd.adoc#features

Check warning on line 137 in harbor/storage/minio_tenant/tenant_argocd_appset.yaml

In Solidarity / Inclusive Language

Match Found

Please consider an alternative to `master`. Possibilities include: `primary`, `main`, `leader`, `active`, `writer`
Raw output
/master/gi
features:
bucketDNS: false
prometheusOperator: false
# Enable JSON, Anonymous logging for MinIO tenants.
# Refer https://github.com/minio/operator/blob/master/pkg/apis/minio.min.io/v2/types.go#L303

Check warning on line 173 in harbor/storage/minio_tenant/tenant_argocd_appset.yaml

In Solidarity / Inclusive Language

Match Found

Please consider an alternative to `master`. Possibilities include: `primary`, `main`, `leader`, `active`, `writer`
Raw output
/master/gi
logging:
anonymous: true
json: true
quiet: true
## Add environment variables to be set in MinIO container (https://github.com/minio/minio/tree/master/docs/config)

Check warning on line 179 in harbor/storage/minio_tenant/tenant_argocd_appset.yaml

In Solidarity / Inclusive Language

Match Found

Please consider an alternative to `master`. Possibilities include: `primary`, `main`, `leader`, `active`, `writer`
Raw output
/master/gi
# stolen from https://github.com/minio/operator/blob/master/examples/kustomization/tenant-letsencrypt/tenant.yaml

Check warning on line 180 in harbor/storage/minio_tenant/tenant_argocd_appset.yaml

In Solidarity / Inclusive Language

Match Found

Please consider an alternative to `master`. Possibilities include: `primary`, `main`, `leader`, `active`, `writer`
Raw output
/master/gi
env:
- name: MINIO_DOMAIN
value: "{{ .harbor_s3_endpoint }}"
## TLS Settings for MinIO
tls:
enabled: false
## Create a secret with private.key and public.crt files and pass that here. Ref: https://github.com/minio/minio/tree/master/docs/tls/kubernetes#2-create-kubernetes-secret

Check warning on line 53 in harbor/storage/minio_vanilla/minio_argocd_appset.yaml

In Solidarity / Inclusive Language

Match Found

Please consider an alternative to `master`. Possibilities include: `primary`, `main`, `leader`, `active`, `writer`
Raw output
/master/gi
certSecret: ""
publicCrt: public.crt
privateKey: private.key
## Trusted Certificates Settings for MinIO. Ref: https://min.io/docs/minio/linux/operations/network-encryption.html#third-party-certificate-authorities
## Bundle multiple trusted certificates into one secret and pass that here. Ref: https://github.com/minio/minio/tree/master/docs/tls/kubernetes#2-create-kubernetes-secret

Check warning on line 59 in harbor/storage/minio_vanilla/minio_argocd_appset.yaml

In Solidarity / Inclusive Language

Match Found

Please consider an alternative to `master`. Possibilities include: `primary`, `main`, `leader`, `active`, `writer`
Raw output
/master/gi
## When using self-signed certificates, remember to include MinIO's own certificate in the bundle with key public.crt.
## If certSecret is left empty and tls is enabled, this chart installs the public certificate from .Values.tls.certSecret.
trustedCertsSecret: ""
replicationPlacment: "001"
extraEnvironmentVars:
WEED_CLUSTER_DEFAULT: "sw"
WEED_CLUSTER_SW_MASTER: "seaweedfs-master.seaweedfs:9333"

Check warning on line 68 in harbor/storage/seaweedfs/seaweedfs_argocd_appset.yaml

In Solidarity / Inclusive Language

Match Found

Please consider an alternative to `MASTER`. Possibilities include: `primary`, `main`, `leader`, `active`, `writer`
Raw output
/master/gi

Check warning on line 68 in harbor/storage/seaweedfs/seaweedfs_argocd_appset.yaml

In Solidarity / Inclusive Language

Match Found

Please consider an alternative to `master`. Possibilities include: `primary`, `main`, `leader`, `active`, `writer`
Raw output
/master/gi
WEED_CLUSTER_SW_FILER: "seaweedfs-filer-client.seaweedfs:8888"
image:
registry: ""
repository: ""
master:

Check warning on line 73 in harbor/storage/seaweedfs/seaweedfs_argocd_appset.yaml

In Solidarity / Inclusive Language

Match Found

Please consider an alternative to `master`. Possibilities include: `primary`, `main`, `leader`, `active`, `writer`
Raw output
/master/gi
enabled: true
replicas: 1
port: 9333
defaultReplication: "000"
disableHttp: false
config: |-
# Enter any extra configuration for master.toml here.

Check warning on line 87 in harbor/storage/seaweedfs/seaweedfs_argocd_appset.yaml

In Solidarity / Inclusive Language

Match Found

Please consider an alternative to `master`. Possibilities include: `primary`, `main`, `leader`, `active`, `writer`
Raw output
/master/gi
# It may be be a multi-line string.
data:
type: "emptyDir"
# type: "existingClaim"
# claimName: "swfs-master-data"

Check warning on line 92 in harbor/storage/seaweedfs/seaweedfs_argocd_appset.yaml

In Solidarity / Inclusive Language

Match Found

Please consider an alternative to `master`. Possibilities include: `primary`, `main`, `leader`, `active`, `writer`
Raw output
/master/gi
logs:
type: "hostPath"
size: ""