Conversation
Member
yxjiang
commented
Dec 2, 2025
- Change default vision encoder to clip-vit-large-patch14-336 (336px)
- Add image_size property to CLIPVisionEncoder
- Add num_visual_tokens property that calculates dynamically from image size
- Update max_length defaults to 1024 for both Phase 1 and Phase 2
- Add validation warnings for insufficient max_length
- Update checkpoint filenames to include pixel resolution (e.g., checkpoint_phase1_fp16_336px.pt)
- Update datasets to auto-calculate num_visual_tokens from image processor
- Update training scripts to pass num_visual_tokens explicitly
- Change default vision encoder to clip-vit-large-patch14-336 (336px) - Add image_size property to CLIPVisionEncoder - Add num_visual_tokens property that calculates dynamically from image size - Update max_length defaults to 1024 for both Phase 1 and Phase 2 - Add validation warnings for insufficient max_length - Update checkpoint filenames to include pixel resolution (e.g., checkpoint_phase1_fp16_336px.pt) - Update datasets to auto-calculate num_visual_tokens from image processor - Update training scripts to pass num_visual_tokens explicitly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.