feat: write separation #875
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
我们业务场景是通过 wokerpool（worker 设置为1） 将所有主逻辑都投递到一个协程中运行的， 所以我们需要异步进行写操作。
但是现在的异步写会继续投递到 workerpool中，这在我们的场景中是无意义的。
这个pr是将所有写操作投递到独立的协程中进行
https://github.com/dickens7/rpcx/blob/04390ab447af4eaad705cb5123b06e97d362aa56/server/server.go#L1114
这里需要注意，当前chan满了之后会直接丢弃消息